CodeTriage icon indicating copy to clipboard operation
CodeTriage copied to clipboard

Published 20 hours ago ā€¢ verified publisher icon codetriage

Port tests over to github actions

Open schneems opened this issue 3 years ago ā€¢ 10 comments
trafficstars

Expected Behavior

When contributors open up PRs tests should run

Current Behavior

Heroku CI only runs for branches inside of the same repo. So when a contributor opens a PR their tests don't run.

Possible Solution

Keep the Heroku tests for now, but ALSO introduce GitHub actions to test the codebase

I'll gladly tag it #hacktoberfest šŸ™šŸ»

schneems avatar Oct 05 '22 01:10 schneems

can you assign me?

shivarm avatar Oct 05 '22 01:10 shivarm

Done

schneems avatar Oct 05 '22 02:10 schneems

Hello. Iā€™m am curious what you think the timeline is for this issue.

schneems avatar Oct 08 '22 22:10 schneems

Hi. I've not heard from you in some time. You're still welcome to work on this, but I also want to open it up. Not having tests trigger on contributor PRs is a bit of a bottleneck during hacktoberfest.

schneems avatar Oct 11 '22 16:10 schneems

Anyone working on this one?

deepakmahakale avatar Oct 12 '22 12:10 deepakmahakale

We could change this the way we did for wicked

deepakmahakale avatar Oct 12 '22 12:10 deepakmahakale

deepakmahakale

you can work now. @deepakmahakale

shivarm avatar Oct 12 '22 12:10 shivarm

@schneems should I start on this?

deepakmahakale avatar Oct 12 '22 12:10 deepakmahakale

@deepakmahakale We are planning to pair on this with @neko314

gregmolnar avatar Oct 12 '22 17:10 gregmolnar

@deepakmahakale We are planning to pair on this with @neko314

Wonderful šŸ‘

deepakmahakale avatar Oct 13 '22 10:10 deepakmahakale