codethesaur.us icon indicating copy to clipboard operation
codethesaur.us copied to clipboard

Update->adding C language

Open akkshayTandon opened this issue 2 years ago • 1 comments

What GitHub issue does this PR apply to?

None

What changed and why?

added data_types, control_structures, io, operators, functions, classes in C language

(If editing Django app) Please add screenshots

Checklist

  • [ ] I claimed any associated issue(s) and they are not someone else's
  • [ ] I have looked at documentation to ensure I made any revisions correctly
  • [ ] I tested my changes locally to ensure they work
  • [ ] (If editing Django) I have added or edited any appropriate unit tests for my changes

Any additional comments or things to be aware of while reviewing?

akkshayTandon avatar Aug 06 '22 19:08 akkshayTandon

I added in a new Github Action ("Validate Meta Info File") to check for changes to meta_info.json. It failed on this PR because your JSON files aren't in [language]/[version]/[files].json format. If you add a version directory under /c/ then move the files in there, it should pass.

geekygirlsarah avatar Aug 30 '22 01:08 geekygirlsarah

Hey @akkshayTandon, I figured I'd check up on this again. Is there anything you need help with on this?

geekygirlsarah avatar Sep 25 '22 22:09 geekygirlsarah

Hi Sarah, ->I tried to resolve the requested changes. -> I am sorry for late review. ->I am new to open source, and this is my first repository i am trying to work with, it will be a help if you guide me. ->Waiting for further update.

akkshayTandon avatar Oct 21 '22 20:10 akkshayTandon

please ignore the review request, still working on it.

akkshayTandon avatar Oct 31 '22 16:10 akkshayTandon

Getting closer. I'm still seeing some "unknown" holes when I test it:

  • data types (7 missing)
  • functions (5 missing)
  • input/output (40+ missing)
  • lists (19 missing)
  • math/operators (2 missing)

You can see the same on the review app: https://codethesaurus-test-pr-508.herokuapp.com/

Can you fill in those empty holes please?

(I'm not seeing files for exception handling, queues/stacks, and strings, which is fine.)

  • removed the "unknown" with either its code or made "not-implemented" : "true"
  • Hi @geekygirlsarah , waiting for re-review.

akkshayTandon avatar Nov 02 '22 18:11 akkshayTandon

This was a very nice experience having contributed for the first time in an open source project. Definitely learned some things. I will continue contributing .

akkshayTandon avatar Nov 10 '22 14:11 akkshayTandon

This was a very nice experience having contributed for the first time in an open source project.

Thanks! You took on a ton of work but I'm glad you liked working on it.

Definitely learned some things. I will continue contributing .

I hope you keep contributing if you can, whether that's here or on other projects. And every project is different too, so your experiences here may not carry over as they have other processes involved. I try to make mine friendly for experienced or inexperienced devs as well as those new and experienced with open source!

geekygirlsarah avatar Nov 14 '22 03:11 geekygirlsarah