sandpack icon indicating copy to clipboard operation
sandpack copied to clipboard

feat(codeeditor): support shell language

Open andrewsemchism opened this issue 2 years ago • 1 comments

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

What kind of change does this pull request introduce?

Add support for shell syntax highlighting.

What is the current behavior?

Shell syntax highlighting is not supported.

What is the new behavior?

Files with the extensions .sh, .shell, .bash, and .zsh will have shell syntax highlighting applied to them.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Added shell example to storybook.

Checklist

  • [ ] Documentation; N/A
  • [X] Storybook (if applicable);
  • [ ] Tests;
  • [X] Ready to be merged;

andrewsemchism avatar Aug 06 '22 19:08 andrewsemchism

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe5ab65b500406410719181817bce3de7db3ddab:

Sandbox Source
Sandpack Configuration

codesandbox-ci[bot] avatar Aug 06 '22 19:08 codesandbox-ci[bot]

@danilowoz Could you re-run the failed Integration tests? I'm not sure what caused that failure. Also, would it possible to get some guidance on fixing the Chromatic deployment "missing project token" failure? Thank you.

andrewsemchism avatar Aug 11 '22 18:08 andrewsemchism

Hey @danilowoz! I just wanted to check in here to see if anything else is needed for a review on this PR. I'd love to start using this in our usage of Sandpack 🙂

jodyheavener avatar Sep 01 '22 17:09 jodyheavener

Implemented additional language support on https://github.com/codesandbox/sandpack/pull/570

danilowoz avatar Sep 15 '22 19:09 danilowoz