codesandbox-client icon indicating copy to clipboard operation
codesandbox-client copied to clipboard

Sandbox can't recognize Subpath imports, compile fail when import npm package which use this syntax

Open pointhalo opened this issue 1 year ago β€’ 8 comments

πŸ› bug report

Preflight Checklist

  • [ ] I have read the Contributing Guidelines for this project.
  • [ ] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Description of the problem

How has this issue affected you? What are you trying to accomplish?

To Reproduce

  1. sandbox can't recognize Subpath imports (https://nodejs.org/api/packages.html#subpath-imports) image

  2. please see this demo: https://codesandbox.io/p/sandbox/vfile-pure-3xfl7w?file=%2Fsrc%2Findex.mjs%3A16%2C1

The new version vfile use this syntax, codesandbox can't preview it.

image

Link to sandbox: link (optional)

https://codesandbox.io/p/sandbox/vfile-pure-3xfl7w?file=%2Fsrc%2Findex.mjs%3A16%2C1

Your Environment

Software Name/Version
Π‘odesandbox
Browser
Operating System

pointhalo avatar Sep 30 '24 06:09 pointhalo

Same

SudoUserReal avatar Sep 30 '24 06:09 SudoUserReal

Hi @pointhalo! I'm sharing the message I've sent you through our Support email here so it can help others too.

Our Sandbox environment does not officially support Node.js. As such, we have introduced support for some critical features such as package management, but we lack feature parity with Node.js. That is also the case with subpath imports.

Still, we are continuously seeking to improve our product, so consider submitting it as a feature request to ensure it is on our product team's radar.

filipelima18 avatar Oct 01 '24 15:10 filipelima18

Interesting... is this supported by bundlers like Vite and Webpack? We might need to support this to get parity with them.

CompuIves avatar Oct 01 '24 15:10 CompuIves

Interesting... is this supported by bundlers like Vite and Webpack? We might need to support this to get parity with them.

Webpack and vite support it.

SudoUserReal avatar Oct 01 '24 18:10 SudoUserReal

Interesting... is this supported by bundlers like Vite and Webpack? We might need to support this to get parity with them.

In our test, mainstream build tools such as webpack, vite, and rspack are all supported. We found that the problem is because we are using @mdx-js/mdx to implement markdown rendering. And vfile is the underlying dependency of mdx-js/mdx(After 2024/07/16, the maintainer of vfile updated their version and used this syntaxοΌ‰

There are many people using mdx. If everyone encounters this problem when using mdx-js/mdx in codesandbox, it may be quite troublesome.

β”‚   └─┬ @mdx-js/[email protected]
β”‚     β”œβ”€β”¬ [email protected]
β”‚     β”‚ β”œβ”€β”¬ [email protected]
β”‚     β”‚ β”‚ └── [email protected] 
β”‚     β”‚ └── [email protected] 
β”‚     β”œβ”€β”¬ [email protected]
β”‚     β”‚ └── [email protected] 
β”‚     └── [email protected]

We sincerely hope that your team can consider providing this supportπŸ™

pointhalo avatar Oct 08 '24 03:10 pointhalo

image

And seems i can't reach this circle community page to submit a feature request

pointhalo avatar Oct 08 '24 12:10 pointhalo

This is on my radar. I will find this week some time to investigate this!

On Tue, Oct 8 2024 at 05:07, pointhalo < @.*** > wrote:

image.png (view on web) ( https://github.com/user-attachments/assets/6c82f62c-1c99-4088-bac8-ca98c33821a2 )

And seems i can't reach this circle community page to submit a feature request

β€” Reply to this email directly, view it on GitHub ( https://github.com/codesandbox/codesandbox-client/issues/8625#issuecomment-2399663439 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAEPKCCIOSPPWJZOJAARSQTZ2PDH3AVCNFSM6AAAAABPCR7GRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGY3DGNBTHE ). You are receiving this because you commented. Message ID: <codesandbox/codesandbox-client/issues/8625/2399663439 @ github. com>

CompuIves avatar Oct 09 '24 01:10 CompuIves

image

And seems i can't reach this circle community page to submit a feature request

This is fixed now and you should be able to access!

filipelima18 avatar Oct 09 '24 13:10 filipelima18