codesandbox-client
codesandbox-client copied to clipboard
codesandbox
use updated astring generator
What kind of change does this PR introduce?
Enhancement / Fix
What is the current behavior?
JSXFragment, JSXSpreadAttributes will not be rendered properly
What is the new behavior?
Handles the above with added code in the original library
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
N/A
Checklist
- [x] Documentation - N/A
- [x] Testing
- [x] Ready to be merged
- [ ] Added myself to contributors table
Waiting on the instruction, to do the above if the team still uses the babel transpiler and is not already handling the above mentioned Tokens elsewhere
This branch is running in CodeSandbox. Use the links below to review this PR faster.
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview
![codesandbox[bot] avatar](https://avatars.githubusercontent.com/in/206332?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 134b07d9200eac0ee35a9d95ab07f6f3f455974c:
| Sandbox | Source |
|---|---|
| Notifications Test | Configuration |
![codesandbox-ci[bot] avatar](https://avatars.githubusercontent.com/in/38409?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey! Thanks for the contribution, do you have an example where we're currently not parsing/rendering this correctly?
Not sure, I didn't go through the entire codebase but the reason for update was the missing JSXEmptyExpression and JSXFragment writers missing in the original code which was derived from v0.1.x of astring-jsx which hasn't been updated with the new additions in acorn-jsx