codesandbox-client icon indicating copy to clipboard operation
codesandbox-client copied to clipboard

Angular 13 with Angular InstantSearch throw an error

Open FabienMotte opened this issue 2 years ago • 4 comments

🐛 Bug Report

Preflight Checklist

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Description of the problem

In local, running this example using Angular 13 and Angular InstantSearch 4.1.0 works fine. But on Codesandbox, an error is thrown: Type NgAisRootModule does not have 'ɵmod' property..

image

In local, running yarn start for the first time converts the Angular InstantSearch library from the View Engine to Ivy:

Processing legacy "View Engine" libraries:
- angular-instantsearch [es2015/esm2015] (https://github.com/algolia/angular-instantsearch.git)
Encourage the library authors to publish an Ivy distribution.
✔ Browser application bundle generation complete.

But I don't know what's happening on CodeSandbox side.

Link to sandbox for reproduction

Thank you!

How has this issue affected you? What are you trying to accomplish?

Examples in our documentation using Angular 13 with Angular InstantSearch no longer work.

Your Environment

Software Name/Version
Codesandbox 57b91069f
Browser Chrome 99.0.4844.51
Operating System macOS 11.6.4

FabienMotte avatar Mar 10 '22 17:03 FabienMotte

Hey @FabienMotte ,

Unfortunately that link goes to an empty Sandbox, do you have a link to the live Sandbox?

JamesACS avatar Mar 18 '22 16:03 JamesACS

Hi @JamesACS, thanks for your message!

The Sandbox should work as the folder exists in our GitHub repo: https://github.com/algolia/doc-code-samples/tree/master/Angular%20InstantSearch/getting-started

It seems related to this issue: https://github.com/codesandbox/codesandbox-client/issues/6443 I can open a new issue if you want as this issue is not related to this one.

In the meantime, you should be able to reproduce the error I mentioned in my previous message using this working Sandbox: https://codesandbox.io/s/github/algolia/doc-code-samples/tree/master/Angular+InstantSearch/e-commerce/

Thanks!

FabienMotte avatar Mar 28 '22 12:03 FabienMotte

Thanks @FabienMotte - We've ID'd this as an issue with our bundler for Angular. I've raised it with the team!

JamesACS avatar Apr 12 '22 14:04 JamesACS

Thank you @JamesACS!

FabienMotte avatar Apr 12 '22 15:04 FabienMotte

Hi ! I wanted to open an issue for these two but I guess it's better here :

  • https://codesandbox.io/s/github/algolia/doc-code-samples/tree/fix-angular-12/angular-instantsearch/infinite-scroll
  • https://codesandbox.io/s/github/algolia/doc-code-samples/tree/fix-angular-12/angular-instantsearch/geo-search

All different error messages but seems like it might be the same bundler issue ?

They both work fine locally and on StackBlitz.

aymeric-giraudet avatar Nov 15 '22 13:11 aymeric-giraudet