codesandbox-client icon indicating copy to clipboard operation
codesandbox-client copied to clipboard

add (vscode-ext) language mask

Open tenbits opened this issue 4 years ago • 4 comments

Hello CSB Team,

I am working on a component-based template engine called Mask. This PR adds a new file extension (.mask) with the syntax support. It would be great, that anyone could create UI components directly from the sandbox.

What kind of change does this PR introduce?

Adds new extension for .mask files.

What is the current behavior?

.mask files are not highlighted

What is the new behavior?

.mask files have proper highlighting

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  • ran dev server locally
  • added new file foo.mask with the content:
import Footer from './Footer'
define Foo extends Footer {
   if (user != null) {
       h1 > 'Hello ~[bind: user.name]'
   }
}

Checklist

  • [x] Testing (https://pr6146.build.csb.dev/s/new)
  • [x] Ready to be merged

Thank you, and let me know if something needs to be changed, Best, Alex

tenbits avatar Sep 17 '21 23:09 tenbits

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 88d1ceb3ec047a26de416763bd2beb2b34f8d9a6:

Sandbox Source
Notifications Test Configuration

codesandbox-ci[bot] avatar Sep 17 '21 23:09 codesandbox-ci[bot]

Build for latest commit https://github.com/codesandbox/codesandbox-client/pull/6146/commits/88d1ceb3ec047a26de416763bd2beb2b34f8d9a6 is at https://pr6146.build.csb.dev/s/new.

lbogdan avatar Sep 17 '21 23:09 lbogdan

Dear Team, any chance to get this merged?

I would like to start creating components demos, and the highlighting would be essential.

Thanks

tenbits avatar Apr 15 '22 10:04 tenbits

It looks good to me Screenshot 2022-05-17 at 10 49 30

danilowoz avatar May 17 '22 10:05 danilowoz