BUB2
BUB2 copied to clipboard
Fixes: [T354304]: Integrate PDL to Commons
Fixes T354304
Proposed Changes
- All proposed changes present in #233 apply here (UI Feedbacks , OAuth2 access token and upload to Commons
- For PDL, figure out a way to create a valid PDF file using the zipped images and then upload the PDF to Commons (as that would be easier to use on Wikisource than individually uploading the book page images).
@okerekechinweotito Just tested. Here's the feedback:
- We are logging and sending highly secure content like OAuth token to Internet Archive which could pose huge security risks. Please do not log and store the OAuth token anywhere.
- Fields such as Commonsmetadata, Isuploadcommons, Oauthtoken should not be sent to Internet Archive.
- If the PDL file is of zip type, the file upload to Commons is not working.
Sample IA file with error: https://archive.org/details/KhalsaAkhbarLahore2August1901 Sample PDL file of zip type: http://www.panjabdigilib.org/webuser/searches/displayPage.jsp?ID=682&page=1&CategoryID=5&Searched=
Couple of things after testing:
- I also find the Username field on the IA metadata list. That needs to be removed as well, I figure.
-
{"level":"error","message":"allJobs getJobs TypeError: Cannot read properties of null (reading 'step')","timestamp":"2024-03-19T00:16:22.981Z"}
got this in my logs when upload to commons hits 50%
Rest seems okay
@Parthiv-M I have removed userName I also uploaded the book you linked without any error. See here - Beta Commons Book on Internet Archive
@okerekechinweotito We shouldn't even be logging oauthtoken
and using or sending it explicitly between components unless absolutely required.
@okerekechinweotito We shouldn't even be logging
oauthtoken
and using or sending it explicitly between components unless absolutely required.
Alright. Please can you have another review