Shane

Results 13 comments of Shane

> @codersjj can you rebase and squash the commits, please? Sure! I've rebased and squashed the commits. However, I noticed an extra merge commit was generated. Is this acceptable, or...

> Thanks for the contribution! The code looks good overall. > > However, the PR does not seem to be addressing #15759 completely (despite the `Resolves: #15759` in the description)....

> There are a total of four instances of 'external accounts', whereas you've only changed one. > > ``` > introduction-to-smart-contracts.rst:of a keypair belonging to :ref:`external accounts`. > introduction-to-smart-contracts.rst:address space:...