coderoad-vscode icon indicating copy to clipboard operation
coderoad-vscode copied to clipboard
verified publisher icon coderoad

WIP: fix Storybook

Open ShMcK opened this issue 3 years ago • 5 comments

Get Storybook working again.

Signed-off-by: shmck [email protected]

ShMcK avatar Mar 23 '22 04:03 ShMcK

I can help you with this. We can have a talk.

SavvyShah avatar Mar 23 '22 16:03 SavvyShah

@SavvyShah I've sent you an email.

There are some remaining issues with the storybook setup:

  1. I have only enabled a single example story. Others can be added in .storybook/main.ts
  2. the addons in storybook 6 have changed (https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#new-addon-presets). with-knobs is deprecated but heavily used in the project
  3. 'babel-plugin-import' which is used to simplify a component library imports doesn't seem to work with webpack anymore (https://www.npmjs.com/package/babel-plugin-import). It's currently disabled.
  4. There are a number of TS errors in the stories.

ShMcK avatar Mar 24 '22 04:03 ShMcK

Can we use a codemod to convert storiesOf to CSF?

SavvyShah avatar Mar 24 '22 07:03 SavvyShah

Hey @ShMcK . Sorry I have been slow in doing this. But I've made a couple of changes and configured an additional story. I have linked a PR where I have made changes. I found that mocking to the global API should be done in preview.ts.

SavvyShah avatar Sep 30 '22 16:09 SavvyShah

Thanks @SavvyShah ! There seem to be some yarn.lock conflicts. These can likely be resolved by deleting the yarn.lock file and running yarn again.

ShMcK avatar Oct 02 '22 16:10 ShMcK