plr icon indicating copy to clipboard operation
plr copied to clipboard

Allow seeing more than 10 or 20 languages

Open NicolasL-S opened this issue 2 years ago • 7 comments

Would it be possible to see more than 10 or 20 languages on the page? Or is it that it relies on too many rankings with at most 20 languages?

NicolasL-S avatar Jan 18 '23 16:01 NicolasL-S

This is on my potential TODO list. It would just require:

  • [ ] Adding a ton more logos
  • [x] Finding a way to download all 300+ Languish languages.
  • [ ] (the easiest) and an Option for 50 or 100

If there is enough interest I can add it soon.

codereport avatar Jan 18 '23 18:01 codereport

https://x.com/tytr_dev/status/1714869445695361049?s=20

I was also interested in this. I just edited the HTML to add an additional option for 100 and it worked pretty well out of the box. I didn't mind the diminished UX due to lack of logos/icons.

If you're open to it, I can try and drop a PR to add options for 50 and 100. Maybe with a small visual indication somewhere about the diminished UX. I think we can probably add the 50/100 options without worrying about it being perfect in the short term (or ever, really).

tytrdev avatar Oct 19 '23 05:10 tytrdev

Although I will say, the list beyond 30 or so does seem potentially questionable, so that could imply a larger problem that needs to be solved.

tytrdev avatar Oct 19 '23 05:10 tytrdev

Actually nevermind, I found some pretty wild visual artifacts after changing a bunch of settings. I'll try and repro tomorrow and maybe do a checkout and see if I can fix it. I might try and add a bunch of logos as well if I can get to it.

tytrdev avatar Oct 19 '23 08:10 tytrdev

@tytrdev It is honestly pretty simple to add more options. The site is writtten in clojurescript and the js is generated from that. If you update this line here then you get more options.

There are only two things from preventing me from doing it at the moment:

  1. I need more logos
  2. I need to update the "exclude edge languages" list then

Also, the UI issue might be known. I have yet to diagnose what causes this.

codereport avatar Oct 19 '23 11:10 codereport

Yeah I'll drop a PR sometime soon.

That UI issue you linked is definitely what I encountered. I may try and take a crack at that as well.

I'm assuming the "exclude edge languages" list is just a list of things that you don't really want treated on equal footing with the rest of the languages? Intuitively I might add e.g. vim script to that list.

tytrdev avatar Oct 19 '23 16:10 tytrdev

@tytrdev

I'm assuming the "exclude edge languages" list is just a list of things that you don't really want treated on equal footing with the rest of the languages? Intuitively I might add e.g. vim script to that list.

Exactly : )

Yeah I'll drop a PR sometime soon.

That'd be awesome. Let me know if you need pointers on anything.

codereport avatar Oct 19 '23 17:10 codereport