documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Link to generated PDF

Open bast opened this issue 2 years ago • 5 comments

We plan to generate PDF as part of the Sphinx workflow. Let's not forget to link to the PDF from somewhere so that we find it.

It is currently called like this: https://coderefinery.github.io/documentation/_static/lesson.pdf

This does not exist yet at time of issue creation.

bast avatar Aug 23 '23 16:08 bast

should the PDF name include the lesson name, so that when it's downloaded it has a good name automatically? (makes automation across all lessons a bit harder. is it worth it? is filename for download something people will even use?)

rkdarst avatar Sep 06 '23 20:09 rkdarst

I would keep a generic name so that we can copy paste the workflow. The inconvenience for the client is minimal IMO.

bast avatar Sep 06 '23 21:09 bast

Now the link is https://coderefinery.github.io/documentation/lesson.pdf

bast avatar Sep 23 '23 12:09 bast

lesson.pdf, lesson (1).pdf, lesson (2).pdf, etc for all lessons would be at least a little bit annoying to me. My browser (and most by default? at least I didn't set it this way) automatically saves with the remote filenames.

To change name: it can be configured in conf.py with pyppeteer_basename. Changing links in all the lessons is a bit annoying, though... maybe not worth it yet? pdf=$(ls *.pdf) is at least minorly scirptable?

rkdarst avatar Sep 23 '23 20:09 rkdarst

"Changing links in all the lessons is a bit annoying, though" - which links are these?

We could provide a bash script that wgets and renames all. But I also don't mind if each has a unique pdf name.

bast avatar Sep 23 '23 21:09 bast