fw-nrfconnect-nrf-docker icon indicating copy to clipboard operation
fw-nrfconnect-nrf-docker copied to clipboard

support releases of NCS

Open amarkevich opened this issue 4 years ago • 8 comments
trafficstars

TBD: update readme

Released versions can be build using

docker build --build-arg NCS_REVISION=${NCS_REVISION} -t fw-nrfconnect-nrf-docker:${NCS_REVISION} .

Tested with v1.4.x. The latest v1.5.0 failed due to https://github.com/nrfconnect/sdk-nrf/pull/4053

Usage:

docker run --rm -v ${PWD}:/workspace fw-nrfconnect-nrf-docker:${NCS_REVISION} \
  west build -p always -b nrf9160dk_nrf9160ns --build-dir /workspace/build/ -- -DCONFIG_SB_SIGNING_KEY_FILE=\"vendor.pem\" /workspace

amarkevich avatar Mar 03 '21 15:03 amarkevich

The GitHub Actions definitions should be updated to include a matrix definition for these "releases":

  • 1.4
  • 1.5
  • master

coderbyheart avatar Mar 03 '21 15:03 coderbyheart

The changes to the Dockerfile include more than "supporting multiple releases of NCS".

Could provide a description in the PR, why this needs to be changed?

coderbyheart avatar Mar 03 '21 15:03 coderbyheart

  1. Sync deps with https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/zephyr/getting_started/index.html#install-required-tools as base (sections 'Installing the required tools' & 'Installing the toolchain' + 'Nordic command line tools' like in original image)
  2. 'Getting the nRF Connect SDK code' completely as final layer. It allow to use this container as is, using for example in CD/CI scenario.

Finally entry point configured to set Zephyr environment which simplify actual command line for container invocation. Any custom image modification can be made using this one as a base.

amarkevich avatar Mar 03 '21 19:03 amarkevich

Tested with v1.4.x. The latest v1.5.0 failed due to nrfconnect/sdk-nrf#4053

master builds fine with the current version: https://github.com/coderbyheart/fw-nrfconnect-nrf-docker/runs/2026841714?check_suite_focus=true

Your build fails because of a Docker error:

COPY failed: file not found in build context or excluded by .dockerignore: stat entrypoint.sh: file does not exist

coderbyheart avatar Mar 04 '21 08:03 coderbyheart

Build updated. Added fix for NCS v1.5.0

amarkevich avatar Mar 04 '21 13:03 amarkevich

TBD: ClangFormat and point to versioned builds

amarkevich avatar Mar 04 '21 14:03 amarkevich

This PR about docker image with full NCS inside for CI builds

amarkevich avatar Nov 18 '21 15:11 amarkevich

Okay, I am still not sure which problem this solves, though.

coderbyheart avatar Nov 18 '21 15:11 coderbyheart