simple-backup icon indicating copy to clipboard operation
simple-backup copied to clipboard

Restore fails

Open atakanau opened this issue 1 year ago • 0 comments

Updates to fix errors when executing SQL lines starting with description line.

BUT; there are still bugs. TRIGGERs cannot be imported.

message | "You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER $\rCREATE TRIGGER trigger_name AFTER INSERT ON table1 FOR ...' at line 1"

line_number | 386 query | "DELIMITER $\rCREATE TRIGGER trigger_name AFTER INSERT ON table1 FOR EACH ROW insert into table2 (id) values (new.id)\r$\rDELIMITER ;\r

MariaDB-10.4.27 mysqlnd 8.2.0 PHP version: 8.2.0

atakanau avatar Jun 09 '23 17:06 atakanau

Can I work on this task? @jesperpedersen

joanjeremiah avatar Apr 25 '24 09:04 joanjeremiah

@joanjeremiah Yes

jesperpedersen avatar Apr 25 '24 12:04 jesperpedersen

I plan to:

  1. Increment log level counters in the pgmoneta_log_line function.
  2. Store these counters in the config struct as an array.
  3. Use this array in prometheus.c's general_information function to log these metrics in the specified manner.

@jesperpedersen Could you confirm if this approach sounds good, or if there are any adjustments you'd recommend?

Thanks!

joanjeremiah avatar Apr 26 '24 12:04 joanjeremiah

Yes, this sound good, so lets see how the patch looks

jesperpedersen avatar Apr 26 '24 13:04 jesperpedersen

How is this going ?

jesperpedersen avatar May 20 '24 07:05 jesperpedersen

@joanjeremiah Ping ?

jesperpedersen avatar May 23 '24 13:05 jesperpedersen

I started working on this. Couldn't find the time to continue. Will work on it, this weekend.

joanjeremiah avatar May 23 '24 13:05 joanjeremiah

@joanjeremiah Still ok on this ?

jesperpedersen avatar Jun 08 '24 15:06 jesperpedersen

@joanjeremiah Still ok on this ?

Sorry, couldnt find time to complete this.

joanjeremiah avatar Jun 09 '24 06:06 joanjeremiah

@joanjeremiah Do you want to be unassigned on it ? It isn't a big task so you should be able to complete it quickly - you can do it

jesperpedersen avatar Jun 09 '24 13:06 jesperpedersen

@joanjeremiah Do you want to be unassigned on it ? It isn't a big task so you should be able to complete it quickly - you can do it

Kindly unassign me

joanjeremiah avatar Jun 09 '24 14:06 joanjeremiah

@joanjeremiah No problem

jesperpedersen avatar Jun 09 '24 15:06 jesperpedersen