dco icon indicating copy to clipboard operation
dco copied to clipboard

pre-commit hook has empty export

Open bassam opened this issue 6 years ago • 1 comments

I have enabled dco and my commit hook has an empty export line:

cat .git/hooks/commit-msg
#!/bin/sh
# INSTALLED BY DCO GEM
export
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby /Library/Ruby/Gems/2.3.0/gems/dco-1.0.1/bin/dco process_commit_message $1
exit $?

on macOS the prints out all export on every commit. looks like this line is the cultprit:

https://github.com/coderanger/dco/blob/master/lib/dco/cli.rb#L147

bassam avatar Dec 02 '18 19:12 bassam

Hmm, might be easier to change the whole thing to exec env #{env stuff} #{ruby stuff}.

coderanger avatar Dec 02 '18 22:12 coderanger