Noah Kantrowitz comments

Results 187 comments of


                                            Noah Kantrowitz

Setting Logger Does Not Propagate To Client-Go

I'm not really sure there is anything we can do about this until client-go also uses logr? That is in-progress but happening slowly (kubelet is targeted for 1.21, for example).

Setting Logger Does Not Propagate To Client-Go

/remove-lifecycle rotten We should revisit this now that some more time has passed. Probably more doable now :)

Support for CRUD sub resources in the Client

There is limited support for the status subresource via https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/client.go#L143

How to use log in my function

Yes, you should pass the context through as the first argument to any other functions and pull out the logger as needed.

Support non-CRUD subresources (like pod logs)

> is there any workarouds? You can use client-go instead.

Introducing ENV instead of flags for operator's `main.go` skeleton manifest

I think you are overstating it that env vars are a best practice. 12factor was an important step in the ops journey for many but it is neither dogma nor...

Introducing ENV instead of flags for operator's `main.go` skeleton manifest

> the reason I'm asking is to know if there's an acceptance to the concept since it's a major chunk ;-) It really depends on how much it complicates things....

Dynamically cache objects to handle permission changes and lower cache size

I don't think permissions changing after startup is a use case we should consider or care about. That's part of the setup process.

⚠ pkg/webhook/admission: use Result.Message instead of Result.Reason

Trying to think of ways this compat break could bite someone. We should be very certain we can't think of any.

Can't delete namespaces from test environment

If this is a priority for your testing setup, I would strongly recommend using Kind or K3s as your test control plane rather than the default one launched by envtest....