smalltalk icon indicating copy to clipboard operation
smalltalk copied to clipboard

Published 20 hours ago • verified publisher icon coderaiser

Remove global font setting for buttons (fix #32)

Open pjeby opened this issue 2 years ago • 3 comments

pjeby avatar Mar 15 '22 16:03 pjeby

I think better to put this style under .smalltalk button

coderaiser avatar Mar 15 '22 16:03 coderaiser

But then people will still have to override it to specify the font-family they want buttons to normally have, so that the buttons will by default match their global styling. Better to fall back to the application's fonts, to ensure compatibility with any i18n/a11y issues for fonts. (A library should really not be setting font families in required CSS, unless it's to use a specialized font like an icon library -- everyone will just end up having to override it with more-specific selectors, adding unnecessary overhead.)

pjeby avatar Mar 15 '22 17:03 pjeby

In this case, would be great to check styles of Cloud Commander and make changes if needed, so everything worked as it was before modification.

Anyways you can always use !important keyword.

coderaiser avatar Mar 15 '22 17:03 coderaiser