vscode-coder icon indicating copy to clipboard operation
vscode-coder copied to clipboard

Hostname changes occasionally

Open mafredri opened this issue 2 years ago • 4 comments

When I'm connected, my hostname looks like this:

Screenshot 2023-01-19 at 22 11 55

However, occasionally it regresses to match the SSH config:

Screenshot 2023-01-19 at 22 11 42

Note CODER: -> SSH: and mafredri/hel -> whatever that is. 😄

A simple way to reproduce:

  1. Connect to workspace
  2. Restart workspace (stop / start), don't touch VSCode (it will show an error)
  3. Once workspace is up and running again, dismiss the error in VS Code and let it reconnect
  4. Observe hostname change

mafredri avatar Jan 19 '23 20:01 mafredri

@mafredri has this happened with newer versions? I feel as though this was due to the extension not starting properly.

kylecarbs avatar Feb 02 '23 17:02 kylecarbs

@kylecarbs I can still reproduce it using the above steps.

I've also noticed something very odd. My workspace using the extension is named mafredri/hel (when it's not coder-vscode--*). However, I also use workspaces without the extension using plain Remote SSH. And sometimes these are named mafredri/hel too (supposed to be coder.work.main)! So it seems like maybe what our extension does somehow affects other hosts too.

mafredri avatar Feb 03 '23 14:02 mafredri

:raised_eyebrow:

kylecarbs avatar Feb 03 '23 15:02 kylecarbs

I do also notice this issue. Occasionally, I also get the hostname starting with coder-vscode.

I've also noticed something very odd. My workspace using the extension is named mafredri/hel (when it's not coder-vscode--*). However, I also use workspaces without the extension using plain Remote SSH. And sometimes these are named mafredri/hel too (supposed to be coder.work.main)! So it seems like maybe what our extension does somehow affects other hosts too.

In the screenshot below, the first entry is actually pointing to a different SSH connection for an Ubuntu server (only noticable by looking at the path: /home/zindach instead of /home/coder/git). When I click on it, it also opens the "non-coder" SSH connection to my server correctly. Just the name is wrong...

Additionally, the "normal" hostname seems to break the "Open Recent" window because of the / after Coder: <username>.

image

ChriZ982 avatar Mar 28 '23 08:03 ChriZ982

Closing because of inactivity. cc: @stirby

matifali avatar Aug 30 '24 14:08 matifali