modules
modules copied to clipboard
Add support for subdomain in jupyterlab module
I changed also the prints in the run.sh to be compatible with /bin/sh according to https://www.shellcheck.net/wiki/SC2028
Hi @framctr, do you plan to finish this? If not, I can help complete this. Thank you :)
@matifali
As I said previously, I cannot verify with subdomain=true and for this reason, I didn't update anything more. If you can verify this it would be great. 😊
Anyway, I can do a final check with the last changes with subdomain false.
I left a few comments and suggestions on possible issues with url.