modules icon indicating copy to clipboard operation
modules copied to clipboard

Add support for subdomain in jupyterlab module

Open framctr opened this issue 1 year ago • 1 comments
trafficstars

Reference issue #313

framctr avatar Oct 08 '24 07:10 framctr

I changed also the prints in the run.sh to be compatible with /bin/sh according to https://www.shellcheck.net/wiki/SC2028

framctr avatar Oct 08 '24 07:10 framctr

Hi @framctr, do you plan to finish this? If not, I can help complete this. Thank you :)

matifali avatar Oct 18 '24 12:10 matifali

@matifali As I said previously, I cannot verify with subdomain=true and for this reason, I didn't update anything more. If you can verify this it would be great. 😊

Anyway, I can do a final check with the last changes with subdomain false.

framctr avatar Oct 18 '24 15:10 framctr

I left a few comments and suggestions on possible issues with url.

matifali avatar Oct 18 '24 15:10 matifali