envbuilder icon indicating copy to clipboard operation
envbuilder copied to clipboard

use FALLBACK_IMAGE when no devcontainer specified

Open bpmct opened this issue 2 years ago • 5 comments
trafficstars

We currently have FALLBACK_IMAGE. If an devcontainer is not specified, we should also support a KITCHENSINK_IMAGE (or use the fallback image for this too). Then, an admin can maintain an image that works in "most" cases.

bpmct avatar Jun 28 '23 20:06 bpmct

I do like this as a generic option to support "Open in Coder" for all projects and would enable a browser extension for Coder (see https://github.com/coder/coder/issues/8589)

michaelbrewer avatar Mar 02 '24 14:03 michaelbrewer

We have several customers heavily using the kitchensink image approach, I think we should invest in this so that an envbuilder template can be a generic template.

Open question: is fallback image good enough, or is there a rationale to have both?

bpmct avatar Apr 10 '24 22:04 bpmct

Fall back would suite my needs. I still need to see if I can get private nexus authentication to work.

michaelbrewer avatar Apr 10 '24 22:04 michaelbrewer

Given: a user runs envbuilder with the following:

  • Git repo that does not contain a devcontainer spec
  • FALLBACK_IMAGE=some_image:some_tag

When: envbuilder is run

Then: envbuilder should gracefully continue without a devcontainer and build an environment consisting of FALLBACK_IMAGE.

johnstcn avatar May 20 '24 08:05 johnstcn

Totally makes sense!

bpmct avatar May 20 '24 19:05 bpmct