enterprise-images icon indicating copy to clipboard operation
enterprise-images copied to clipboard

DRAFT: Add multiarch docker

Open tuananh opened this issue 1 year ago • 4 comments

Fixes: #185

I'm testing in my fork so I use runs-on: ubuntu-latest for now. Will change before the PR lands.

Summary:

  • Use docker buildx bake to build multi-arch image.
  • Enable linux/amd64 and linux/arm64 for now
  • I have only update the base image for now. I'm not sure if other images have all the packages needed for arm64. Potentially, python or any instruction we download binaries from other places.
  • Build seems to work fine in my fork (ignore the scan image step) https://github.com/tuananh/enterprise-images/actions/runs/7217598019/job/19665669577

tuananh avatar Dec 15 '23 03:12 tuananh

@johnstcn is this something you ok with so that I can proceed?

tuananh avatar Dec 15 '23 03:12 tuananh

@johnstcn is this something you ok with so that I can proceed?

Hey, so the basic approach looks fine to me. However, I'd like to do some further TLC on this repo before adding multi-arch images if that's OK?

johnstcn avatar Dec 15 '23 17:12 johnstcn

@johnstcn is this something you ok with so that I can proceed?

Hey, so the basic approach looks fine to me. However, I'd like to do some further TLC on this repo before adding multi-arch images if that's OK?

Sure :)

tuananh avatar Dec 16 '23 03:12 tuananh

@johnstcn is this something you ok with so that I can proceed?

Hey, so the basic approach looks fine to me. However, I'd like to do some further TLC on this repo before adding multi-arch images if that's OK?

Sure :)

I had a poke around at this in cj/buildx, I can get a certain distance before running into package issues. Will continue poking next chance I get.

johnstcn avatar Dec 19 '23 22:12 johnstcn