enterprise-helm icon indicating copy to clipboard operation
enterprise-helm copied to clipboard

Modify RBAC roles to be Openshift/OKD compliant

Open holzman opened this issue 2 years ago • 1 comments

When enumerating rules in a role, providing multiple apiGroups and resources leads to invalid resource apiGroups combinations. E.g.:

  • apiGroups: ["", "apps"] resources: ["pods", "deployments"] rules: ["create"]

This allows "create" for pods and apps/deployments, but also invalid combinations like

apiVersion: v1 kind: deployments

Openshift/OKD rejects adding these rules - users cannot add permissions that they do not already have; and users of course don't have access granted to create invalid resources like deployments.v1.

Signed-off-by: Burt Holzman [email protected]

holzman avatar Jun 29 '22 16:06 holzman

This patch also removes any permissions that aren't permitted by standard openshift/OKD users -- in particular, write-access to events (create/update/patch/delete/deletecollection); a few sets of eyes should verify that that functionality isn't needed. (If it is, the installation docs need to be updated to create a new SCC with those privileges).

holzman avatar Jun 29 '22 16:06 holzman

closing in favor of #273. thank you for your contribution! @holzman

ericpaulsen avatar Dec 07 '22 23:12 ericpaulsen