code-server icon indicating copy to clipboard operation
code-server copied to clipboard

#5374 make requirements clear

Open BelphegorPrime opened this issue 2 years ago • 2 comments

Fixes #5374

BelphegorPrime avatar Jul 24 '22 06:07 BelphegorPrime

I wonder if we should say vCPU? I see that terminology in Google Cloud and AWS.

code-asher avatar Jul 25 '22 18:07 code-asher

Codecov Report

Merging #5375 (849c2e8) into main (0e9ec02) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5375   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files          30       30           
  Lines        1672     1672           
  Branches      366      366           
=======================================
  Hits         1211     1211           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e9ec02...849c2e8. Read the comment docs.

codecov[bot] avatar Jul 25 '22 18:07 codecov[bot]

Agreed, vCPU makes more sense.

jsjoeio avatar Aug 08 '22 22:08 jsjoeio

image

I don't have permission to push to your branch so I'm going to close and open a new PR

jsjoeio avatar Aug 08 '22 22:08 jsjoeio