code-server icon indicating copy to clipboard operation
code-server copied to clipboard

Can't login the github and tabnine

Open linjiahao962889027 opened this issue 3 years ago • 7 comments

OS/Web Information

  • Web Browser: Edge-97.0.1072.62
  • Local OS: Window10/11
  • Remote OS: WSL-2 (Windows11 Ubuntu-20.04 LTS) ( Container Ubuntu-20.04 LTS)
  • Remote Architecture: nginx proxy
  • code-server --version: 4.0.1

Steps to Reproduce

  1. Click login github
  2. Click continue in the page of login github
  3. Callback to the code-server
  4. Without response when click login tabnine
  5. Can't open the page of tabnine

Expected

Login github success

Actual

Reject the forbid page, and the url of callback is 404;

Logs

Screenshot

image image image image image

Notes

This issue can be reproduced in VS Code: No

linjiahao962889027 avatar Jan 19 '22 04:01 linjiahao962889027

have been facing the same issue since upgraded to 4.0.1. Will see if downgrading helps...

kimgiftww avatar Jan 23 '22 06:01 kimgiftww

have been facing the same issue since upgraded to 4.0.1. Will see if downgrading helps...

After downgraded to 3.12.0 and set the ssl working ( https://coder.com/docs/code-server/latest/guide#using-lets-encrypt-with-nginx ) , I am able to login to github from code-server again.

kimgiftww avatar Jan 23 '22 08:01 kimgiftww

I cannot seem to be able to login either

code-server: v4.0.1
 VS Code: v1.63.0
Commit: 735c6da829535969ff7193c79379299e4a1cb9bc
Date: 2022-01-05T17:51:28Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.137 Safari/537.36

hcoohb avatar Jan 23 '22 09:01 hcoohb

I can reproduce this issue on code-server with:

  • Client: Firefox Developer Edition (on Ubuntu 18.04 system)
  • Server: code-server 4.0.1 (installed on Ubuntu 20.04 system)

I remember that there was a JavaScript Error on the browser console when Forbidden dialog is shown. Frankly, the specific client is only one that shows "Forbidden" error during GitHub login.

I can't attach my log at the moment (I am away from my machine at the moment). But I hope this information can help the troubleshooting process.

Alex4386 avatar Jan 28 '22 07:01 Alex4386

Any updates on Getting Web VSCode and TabNine working together? I’ve tried port-forwarding 5555 on localhost to the remote server’s port 5555 with some limited success.

ksylvan avatar Sep 11 '22 20:09 ksylvan

We were working with their team on this. Let me find out!

jsjoeio avatar Sep 12 '22 18:09 jsjoeio

For TabNine, after port-forwarding 5555 from the remote to localhost, I'm seeing these kinds of JavaScript errors when visiting the TabNine hub at localhost:5555:

react-dom.production.min.js:216 TypeError: Cannot read properties of undefined (reading 'includes')
    at e.value (useFeatureFlags.ts:23:30)
    at settings.ts:113:19
    at jue (AddtionalSettings.tsx:26:7)
    at aa (react-dom.production.min.js:157:137)
    at Uo (react-dom.production.min.js:267:460)
    at Os (react-dom.production.min.js:250:347)
    at ks (react-dom.production.min.js:250:278)
    at ws (react-dom.production.min.js:250:138)
    at ys (react-dom.production.min.js:243:163)
    at react-dom.production.min.js:123:115

Uncaught TypeError: Cannot read properties of undefined (reading 'includes')
    at e.value (useFeatureFlags.ts:23:30)
    at settings.ts:113:19
    at jue (AddtionalSettings.tsx:26:7)
    at aa (react-dom.production.min.js:157:137)
    at Uo (react-dom.production.min.js:267:460)
    at Os (react-dom.production.min.js:250:347)
    at ks (react-dom.production.min.js:250:278)
    at ws (react-dom.production.min.js:250:138)
    at ys (react-dom.production.min.js:243:163)
    at react-dom.production.min.js:123:115

See https://github.com/codota/TabNine/issues/305

ksylvan avatar Sep 12 '22 22:09 ksylvan

We were working with their team on this. Let me find out.

Any news on this?

ksylvan avatar Oct 02 '22 18:10 ksylvan

I think next steps is for me to work on https://github.com/coder/code-server/issues/1936#issuecomment-1247072800

I'm hoping to start on it today. Feel free to subscribe to that issue for updates. Also, let me know if you're interested in helping!

jsjoeio avatar Oct 04 '22 16:10 jsjoeio

Was already subscribed to that issue, and sure, I might be able to test something next week.

ksylvan avatar Oct 04 '22 19:10 ksylvan

In case this helps, I was able to render the TabNine hub page in a separate browser tab by the tedious procedure listed here:

https://github.com/ksylvan/remote-coding/blob/main/README.md#a-note-on-using-tabnine-and-vscode-web

ksylvan avatar Oct 04 '22 20:10 ksylvan

That's great! At least there is a workaround. Hoping my fix eliminates the need for that.

jsjoeio avatar Oct 05 '22 17:10 jsjoeio

I missed this issue but this was eventually fixed a while back.

code-asher avatar Jul 11 '24 23:07 code-asher