syclacademy
syclacademy copied to clipboard
Eradicate `.select_device()`
There are still some old Java style code like
auto gpuDevice = gpu_selector_v.select_device();
in Lesson_Materials/Lecture_5_Device_Discovery/index.html
for SYCLcon 2021 which should be replaced by just
device gpuDevice { gpu_selector_v };
Probably the part "Creating a custom device selector" can be also updated to just using lambda.
Also Code_Exercises/Exercise_05_Device_Selection/solution.cpp
should be updated to modern SYCL 2020 too.
The selector in Code_Exercises/Exercise_07_USM_Selector/solution.cpp
should be modernized too.
The selector in Code_Exercises/Exercise_08_USM_Vector_Add/solution.cpp
should be modernized too.
The selector in Code_Exercises/Exercise_09_Synchronization/solution.cpp
and in should be modernized too.
The selector in Code_Exercises/Exercise_10_Managing_Dependencies/solution.cpp
and in should be modernized too.
This is part of a more general problem: https://github.com/codeplaysoftware/syclacademy/issues/73
Can this be closed since #85 has been merged now @keryell ?
Oops! It is still used in version presented by @jamesreinders right now in Lecture_05_Device_Discovery
! :-(
I have looked at the latest main
and there are still:
auto gpuDevice = gpu_selector{}.select_device();
auto chosenDevice = default_selector{}.select_device();
And there are still 3 times struct my_gpu_selector : public device_selector
and its content.