SYCL-ML icon indicating copy to clipboard operation
SYCL-ML copied to clipboard

Changes to build the examples under MSVC

Open mcleary opened this issue 8 years ago • 4 comments

The FindComputeCpp.cmake was updated to the latest version. The download mechanism for the mnist database was changed to use CMake file command. The file smo.hpp had some incompatibilities with MSVC.

mcleary avatar Dec 25 '17 20:12 mcleary

My mistake on the eigen.patch. I will restore the patch to the original version.

mcleary avatar Dec 26 '17 16:12 mcleary

It's alright. At least people can see what needs to be done if they want to try to make it work as well :) Hopefully, we'll have a cleaner solution soon.

Rbiessy avatar Dec 26 '17 16:12 Rbiessy

@Rbiessy is this patch still relevant? If it is let me know and I will update it.

mcleary avatar Feb 19 '19 13:02 mcleary

Well I would definitely want to merge it if I had time to work on this project but I don't think it will happen. The changes in smo.hpp are the only issue I see. I would need to clean the usage of constants and test again on Linux and Windows... Do you want to close this PR?

Rbiessy avatar Feb 21 '19 12:02 Rbiessy