simple-navigation icon indicating copy to clipboard operation
simple-navigation copied to clipboard

Support 'tag' template helper within renderer

Open Flauschbaellchen opened this issue 4 years ago • 1 comments

If using a custom renderer it is not possible to use the tag helper which is a shorter variant for content_tag and is preferred by Rails style guides. The SimpleNavigation::Renderer::Base does not delegate tag to the template adapter.

Documentation: https://github.com/rails/rails/issues/25195 https://docs.rubocop.org/rubocop-rails/cops_rails.html#railscontenttag

It would be great to see this implemented. Currently I've excluded any renderers from Rubocop's auto-correction feature.

Flauschbaellchen avatar Jun 21 '20 10:06 Flauschbaellchen

It would be great if you could contribute with a PR, thanks!

andi avatar Jun 23 '20 08:06 andi