Jose A. Iñigo

I guess we are expected to open the scope using the observation located in the context, aren't we? This allowed the creation of the traceId/spanId. However the WebClient doesn't seem...

@marcingrzejszczak thanks for the clarification, I'll go over the references you provided.

@marcingrzejszczak I've updated the sample, now it looks like this: ``` @RestController @SpringBootApplication class DemotracingApplication( private val webClient: WebClient, private val observationRegistry: ObservationRegistry, private val tracer: Tracer ) { private...

@wilkinsona How strange, I updated it to use the `WebClient.Builder` but still see that requests aren't being correlated. The sample project I'm using is available here in case you can...

I had a look at the Webflux sample and adapted the code: ``` @GetMapping("/hello") fun hello(): Mono { return Mono.deferContextual { contextView: ContextView -> ContextSnapshot.setThreadLocalsFrom(contextView, ObservationThreadLocalAccessor.KEY) .use { scope: ContextSnapshot.Scope...

> > It seems the change from Sleuth to Micrometer Tracing is going to need quite a lot of work on our codebases. Can you confirm this is the proper...

@marcingrzejszczak `micrometer-core` is actually on the classpath, I'm setting the context using asContextElement: ``` class DemotracingApplication( private val webClient: WebClient, private val tracer: Tracer, private val observationRegistry: ObservationRegistry ) {...

What I've seen so far is: ``` @GetMapping("/hello") suspend fun hello(): String { val context: CoroutineContext = observationRegistry.asContextElement() return withContext(context) { ``` When `withContext` is invoked it ends up calling...

@rp199 you nailed it! I agree with you, things were quite easier with Sleuth, where all the instrumentation was completely transparent from our code. This new approach feels kind of...

@rp199 you mentioned that you applied it using a filter, I guess you meant a `HandlerFilterFunction` implementation, right? Would you mind showing some code of the function|handler|filter? I was wondering...