codemonkeynorth

Results 34 comments of codemonkeynorth

@DAreRodz noted. Still having trouble with e2e on windows theoretically I’m only adding some strings and therefore there’s no real need to test everything? (that part passed anyway, I’m just...

@DAreRodz well the first is `Docker is not running. Please start it or use `--wp off`.` so if i add that last flag I'm getting ``` Error: Cannot find module...

note we should also maybe add these non-standard items https://react-cn.github.io/react/docs/tags-and-attributes.html#html-attributes "autoCapitalize", "autoCorrect", "autoSave"

@atanas-dev could this be released please? what issues might it cause as it fixes the problem?

this can be fixed in `javascript\aspectRatioOverlay.js` https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/ce9827a7c51a9f69bf62c634e35d34fa75ee1833/javascript/aspectRatioOverlay.js#L23 the issue is the tabs have been changed ```javascript if(tabIndex == 0){ targetElement = gradioApp().querySelector('div[data-testid=image] img'); } else if(tabIndex == 1){ targetElement =...

this should futureproof it a little, since the button index and tab index should match https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/ce9827a7c51a9f69bf62c634e35d34fa75ee1833/javascript/aspectRatioOverlay.js#L23 ```javascript var tabIndex = get_tab_index('mode_img2img') let tabs = gradioApp().getElementById('mode_img2img').querySelectorAll('div.tabitem'); let tab = tabs[tabIndex]; let...

agreed if the url / querystring is `https://www.example.com?foo=bar` then `sanitize_url($_SERVER['QUERY_STRING'])` would return `http://foo=bar`.. it should just be `foo=bar` I'm not sure if `sanitize_text_field` is the correct function to use though...

thanks. I have a few test sites I can try it on if you need me to check before release. I noticed the default value for `$single` is actually false...

found another temporary workaround, for anybody awaiting a fix: `[myshortcode]` `[myshortcode param="foo"]` ``` [if exists][format split="{}" part=2]{PARAM}[/format][show] param was not passed [else] param was passed as {PARAM} [/if] ``` what...