shoestrap-3
shoestrap-3 copied to clipboard
codemonkey-jack
Easier to change name of theme
One cannot change the name of the theme from Shoestrap (for custom theme) without changing source These two commits fix this (other than style.css still could be overwritten).
The only problem I see with this is child themes...
The options should reflect the parent theme's name and not the child. That's why it's hard-coded at the moment.
If you make it so it's the parent theme's name instead I would have no bjection in merging this. :+1:
FYI we've recently started completely rebuilding the theme using the customizer + twig (no redux).
If you're interested in helping out (it still has a looong way to go) the new repo is here: https://github.com/wpmu/shoestrap
Are there any plugins needed to run shoestrap 4? I am getting an error about Timber.
Yes, it requires this plugin: http://wordpress.org/plugins/timber-library/ We're working on embedding it in the theme so it won't be necessary to install it as a plugin, but untill we do it's required.
I've been thinking about this... The changes you made also change the option name in the database: https://github.com/shoestrap/shoestrap-3/pull/583/files#diff-78cd5aa3783a74555c9938a2a81d01c6R27
That would essentially break the theme for anyone that already has it installed, wouldn't it?
Only if they changed the name. I was thinking more for developers.