codemod icon indicating copy to clipboard operation
codemod copied to clipboard

docs(matchers): correcting identifier name

Open SeaOfTea opened this issue 2 years ago • 4 comments

  • updating the docs to use the correct identifier name in the deep matches section example

SeaOfTea avatar Jun 28 '22 16:06 SeaOfTea

Hey @eventualbuddha, thank you so much for the codemod package. I'm loving it so far! But also have some questions on how to do things, is raising an issue a good place for this?

Regarding this PR though, I noticed this small issue while reading the docs. Is there anything further I need to do to get the checks running?

SeaOfTea avatar Jul 04 '22 12:07 SeaOfTea

Is it because it's from a fork?

SeaOfTea avatar Jul 04 '22 13:07 SeaOfTea

But also have some questions on how to do things, is raising an issue a good place for this?

Sure, that works.

Regarding this PR though, I noticed this small issue while reading the docs. Is there anything further I need to do to get the checks running?

I'm unsure why they’re not running. I’ll look into it.

eventualbuddha avatar Jul 04 '22 16:07 eventualbuddha

According to this, there should be an “Approve and run” button but it’s not there. I’ll merge this manually later.

eventualbuddha avatar Jul 04 '22 16:07 eventualbuddha