Quiz

[marvinrusinek]

Hi Kirill,

I've added a quiz branch (https://github.com/marvinrusinek/codelab/tree/quiz). Please can you take a look at it and let me know if anything needs to be changed.

Marvin

[NothingEverHappens]

I just pushed the latest version in the repo, see if things will work now

[marvinrusinek]

Hello Kirill,

I added several more commits to this pull request. A couple more issues came up during testing and am still working on it.

Marvin

[marvinrusinek]

This is all very old code... I'm going to try to merge the old repo with the new one.

On Sat, Aug 29, 2020 at 5:41 PM NothingEverHappens [email protected] wrote:

@NothingEverHappens commented on this pull request.

In apps/playground/src/app/quiz/containers/dependency-injection-quiz/dependency-injection-quiz.component.ts https://github.com/codelab-fun/codelab/pull/1229#discussion_r479692687:

•  questionText: 'In which of the following does dependency injection occur?',
  

•  options: [
  

•    { optionValue: 1, text: '@Injectable()' },
  

•    { optionValue: 2, text: 'constructor' },
  

•    { optionValue: 3, text: 'function' },
  

•    { optionValue: 4, text: 'NgModule' },
  

•  ],
  

•  answer: 2,
  

•  explanation: 'object instantiations are taken care of by the constructor in Angular'
  

• }
• ];
• constructor(private route: ActivatedRoute, private router: Router) {
• this.route.paramMap.subscribe(params => {

•  this.setQuestionIndex(+params.get('index'));  // get the question ID and store it
  

•  this.question = this.getQuestion;
  

just make question a getter?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/codelab-fun/codelab/pull/1229#pullrequestreview-478156373, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLUC72VGTZC2XGMIBXHRTDSDFYYVANCNFSM4KCHGTRA .