journal-policy-tracker-frontend icon indicating copy to clipboard operation
journal-policy-tracker-frontend copied to clipboard

Published 20 hours ago • verified publisher icon codeisscience

Added validation checks to password field in sign up form

Open oneknucklehead opened this issue 2 years ago • 5 comments

Pull Request Template

Description

Adds validation to the password field in the sign up form. Checks whether the password is 8 or more characters long, contains upper an lowercase letters and special characters using regex expression.

Fixes #143

Type of change

Please delete options that are not relevant.

  • [X] New feature (non-breaking change which adds functionality).

Additional Context (Please include any Screenshots/gifs if relevant)

https://user-images.githubusercontent.com/75200954/164198888-bce49de7-afbc-415d-8729-030579fdf675.mp4

oneknucklehead avatar Apr 20 '22 09:04 oneknucklehead

Hey @padmajabhol can you please merge this?

oneknucklehead avatar May 10 '22 12:05 oneknucklehead

Hey @padmajabhol can you please merge this?

I only review PRs. I don't think I should merge a PR before the approval of either of the mentors. Though I assure that every PR counts has a solid contribution regardless they are merged or not.

padmajabhol avatar May 10 '22 16:05 padmajabhol

Hey @padmajabhol can you please merge this?

I only review PRs. I don't think I should merge a PR before the approval of either of the mentors. Though I assure that every PR counts has a solid contribution regardless they are merged or not.

Okay! I said this because another bug I worked on got committed to this PR. Issue #157

oneknucklehead avatar May 10 '22 19:05 oneknucklehead

Does this PR solves both #143 and #157?

padmajabhol avatar May 11 '22 14:05 padmajabhol

Does this PR solves both #143 and #157?

yes it does.

oneknucklehead avatar May 11 '22 14:05 oneknucklehead