translations icon indicating copy to clipboard operation
translations copied to clipboard

[gl] Galician Locale Translation

Open nunhes opened this issue 1 year ago • 2 comments

Description Galician Locale Translation

Checklist:

  • [✔️] Translate to Galician
  • [✔️] Create GalicianTranslationTest
  • [✔️] Test Passed
  • [✔️] Include changes on README.md. Galician language added

nunhes avatar Feb 17 '24 21:02 nunhes

Thank you for sending this PR!

You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin. See signing. Note that all your commits must be signed. If you have an unsigned commit, you can sign the previous commits by referring to gpg-signing-old-commits.

kenjis avatar Feb 18 '24 00:02 kenjis

Thank you for fixing TranslationsCodeTest.

The four commits are not signed yet. Sign all commits. I recommend you set up git to sign all commits automatically, and squash this branch. Screenshot 2024-02-19 13 39 12

kenjis avatar Feb 19 '24 04:02 kenjis

There are missing translations. "CLI.generator.className.test", "Validation.field_exists". Also we cannot merge commits without signing. If you can't sign old commits, please create a new PR.

  1. Translations\Tests\GalicianTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "gl" ('gl') Failed asserting that the language keys "CLI.generator.className.test", "Validation.field_exists" in the main repository are included for translation in "gl" locale. Failed asserting that an array is empty.

kenjis avatar Apr 14 '24 23:04 kenjis

Hi @nunhes , will you be able to address the test failure?

There was 1 failure:

1) Translations\Tests\GalicianTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "gl" ('gl')
Failed asserting that the language keys "CLI.generator.className.test", "Validation.field_exists" in the main repository are included for translation in "gl" locale.
Failed asserting that an array is empty.

/home/runner/work/translations/translations/tests/Language/AbstractTranslationTestCase.php:170

paulbalandan avatar Apr 22 '24 13:04 paulbalandan

Closing for no activity for almost 2 months now.

paulbalandan avatar Jun 17 '24 11:06 paulbalandan