translations icon indicating copy to clipboard operation
translations copied to clipboard

Published 20 hours ago • verified publisher icon codeigniter4

[de] Create Errors.php

Open sba opened this issue 2 years ago • 3 comments

german translation file for strings added in 4.3

sba avatar Aug 03 '22 15:08 sba

@paulbalandan https://github.com/codeigniter4/CodeIgniter4/pull/6288 is merged into 4.3 branch. So the new lang file does not exist in develop branch.

What do we do?

kenjis avatar Aug 04 '22 00:08 kenjis

The tests were designed to test against develop only. So, I guess hold this off until 4.3 gets merged to develop?

paulbalandan avatar Aug 04 '22 02:08 paulbalandan

I see. I'm not sure but it might be a good way.

kenjis avatar Aug 04 '22 03:08 kenjis

  1. Translations\Tests\GermanTranslationTest::testAllConfiguredLanguageKeysAreIncluded with data set "de" ('de') Failed asserting that the language key "HTTP.localeNotSupported" in the main repository is included for translation in "de" locale. Failed asserting that an array is empty.

kenjis avatar Jan 11 '23 23:01 kenjis

@sba will you be able to address the failing tests?

paulbalandan avatar Jan 14 '23 17:01 paulbalandan

@sba will you be able to address the failing tests?

the missing key I added, but I don't know what causes Failed asserting that an array is empty.

sba avatar Jan 15 '23 14:01 sba

@sba It is the same error with Failed asserting that the language key "HTTP.localeNotSupported" in the main repository is included for translation in "de" locale. It is original error message from PHPUnit.

kenjis avatar Jan 15 '23 23:01 kenjis