shield icon indicating copy to clipboard operation
shield copied to clipboard

Published 20 hours ago • verified publisher icon codeigniter4

Remove superfluous `--using-cache` option

Open paulbalandan opened this issue 3 years ago • 3 comments

When using nexusphp/cs-config, the --using-cache is default true if not provided. https://github.com/NexusPHP/cs-config/blob/e9092a9ab3a59c982bf0c79c89df36a7b2c0b86e/src/Factory.php#L122

paulbalandan avatar Aug 15 '22 04:08 paulbalandan

I don't know why, but the original setting was --using-cache=no. And the option does not show in the help vendor/bin/php-cs-fixer --help. So I leave the option to easily know the option name.

I'm fine with this PR.

kenjis avatar Aug 15 '22 05:08 kenjis

Related : #340

datamweb avatar Aug 15 '22 05:08 datamweb

It came from my default toolkit: https://github.com/tattersoftware/codeigniter4-tools/blob/develop/src/composer.php#L121

These are primarily for my library development, since maintaining the development tools across 40 repos is a nightmare. These libraries are mostly pretty small so I prefer to run without cache as my default. I'm fine with speeding things up for Shield, which is a larger scope. Also good with removing the argument here after @paulbalandan's explanation.

MGatner avatar Aug 15 '22 10:08 MGatner

Are there blocking issues/concerns preventing the merge?

paulbalandan avatar Aug 19 '22 10:08 paulbalandan