shield icon indicating copy to clipboard operation
shield copied to clipboard

refactor: Session->checkAction method

Open grimpirate opened this issue 1 year ago • 2 comments

Description The checkAction method of the Session authenticator class includes unneeded assignment statements and comparisons. No functional change.

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

grimpirate avatar Oct 28 '24 06:10 grimpirate

@grimpirate Please run command:

composer cs-fix

datamweb avatar Nov 01 '24 16:11 datamweb

Please make the edit to include spaces after the not (!) operators. I don't have a local environment with GPG signing set up for this. I make these changes via the github online editor so I lack the capability to squash commits together and other such features. Thank you.

grimpirate avatar Nov 01 '24 17:11 grimpirate

Closing this because of inactivity.

grimpirate avatar Jul 15 '25 15:07 grimpirate