shield icon indicating copy to clipboard operation
shield copied to clipboard

fix: Update active date only for users activated and not banned.

Open warcooft opened this issue 1 year ago • 1 comments

Description See https://github.com/codeigniter4/shield/discussions/1179#discussion-7084659

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [x] User guide updated
  • [x] Conforms to style guide

warcooft avatar Aug 26 '24 07:08 warcooft

Because the existing PHPUnit tests do not fail, there seems no test code for recordActiveDate. I would like you to add test code:

  • does not update active date for a user that is not activated
  • does not update active date for a user that is banned

kenjis avatar Aug 26 '24 23:08 kenjis