shield icon indicating copy to clipboard operation
shield copied to clipboard

Published 20 hours ago • verified publisher icon codeigniter4

chore: use organization workflows for improve actions

Open datamweb opened this issue 1 year ago • 8 comments

Description Explain what you have changed, and why.

Checklist:

  • [ ] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

datamweb avatar Feb 28 '24 14:02 datamweb 

[Invalid workflow file: .github/workflows/smart-commenting.yml#L21](https://github.com/codeigniter4/shield/actions/runs/8082359503/workflow)
error parsing called workflow
".github/workflows/smart-commenting.yml"
-> "codeigniter4/.github/.github/workflows/label-signing.yml@main" (source branch with sha:d8ea2aa19c2eb2b6482402133f328a6105d2aa22)
: workflow is not reusable as it is missing a `on.workflow_call` trigger

[Invalid workflow file: .github/workflows/smart-commenting.yml#L23](https://github.com/codeigniter4/shield/actions/runs/8082300366/workflow)
error parsing called workflow
".github/workflows/smart-commenting.yml"
-> "codeigniter4/.github/.github/workflows/label-add-conflict-all-pr.yml@main" (source branch with sha:d8ea2aa19c2eb2b6482402133f328a6105d2aa22)
: workflow is not reusable as it is missing a `on.workflow_call` trigger

See https://github.com/orgs/community/discussions/38954

datamweb avatar Feb 28 '24 15:02 datamweb

I'm not sure, but we can't use branch names in this workflow, only tag names?

kenjis avatar Feb 28 '24 22:02 kenjis

@datamweb I sent PR https://github.com/codeigniter4/.github/pull/26

kenjis avatar Mar 22 '24 23:03 kenjis 

[Invalid workflow file: .github/workflows/smart-commenting.yml#L20](https://github.com/codeigniter4/shield/actions/runs/8398026883/workflow)
The workflow is not valid. .github/workflows/smart-commenting.yml (Line: 20, Col: 3): Error calling workflow 'codeigniter4/.github/.github/workflows/label-signing.yml@main'. The workflow is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'.

~~But why we have set access pull-requests: write in .github https://github.com/codeigniter4/.github/blob/567aab8e987fccac5b1864d0635ec087b12d0866/.github/workflows/label-signing.yml#L12-L14~~

datamweb avatar Mar 23 '24 00:03 datamweb

It seems to be working fine now, please check it.

datamweb avatar Mar 23 '24 01:03 datamweb

What is Smart Commenting-refactor-smarting-comment?

Smart Commenting: .github#L1 Canceling since a higher priority waiting request for 'Smart Commenting-refactor-smarting-comment' exists https://github.com/codeigniter4/shield/actions/runs/8398353923

kenjis avatar Mar 23 '24 01:03 kenjis

add-comment-for-conflict / Check Conflicts

Run IFS=$'\n' # Set Internal Field Separator to newline to handle array elements GraphQL: Resource not accessible by integration (addLabelsToLabelable) Error: Process completed with exit code 1. https://github.com/codeigniter4/shield/actions/runs/8398353923/job/23003407973

kenjis avatar Mar 23 '24 01:03 kenjis

~~codeigniter4/.github/.github/workflows/label-add-conflict-all-pr.yml@main" (source branch with sha:d8ea2aa19c2eb2b6482402133f328a6105d2aa22)\r\n: workflow is not reusable as it is missing a on.workflow_call trigger~~

datamweb avatar Mar 23 '24 08:03 datamweb