settings icon indicating copy to clipboard operation
settings copied to clipboard

Bypass config($class) performance impact

Open pixobit opened this issue 1 year ago • 2 comments

Description Huge performance improvement. config($class) seems to be an expensive process, and we don't really need it before falling back to the config property. Note: Try creating a for loop of 1000 to get a settings value

pixobit avatar May 23 '24 09:05 pixobit

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

[!IMPORTANT] We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See also the documentation in the main repository: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

kenjis avatar May 23 '24 12:05 kenjis

Do you need any help completing this PR?

kenjis avatar May 31 '24 23:05 kenjis

Closing due to no activity.

paulbalandan avatar Feb 19 '25 15:02 paulbalandan