queue icon indicating copy to clipboard operation
queue copied to clipboard

fix: remove option to use a custom config file via service

Open michalsn opened this issue 7 months ago • 1 comments

Description This PR removes the ability to define a custom config file for the queue (when using service()). From now on, configuration will rely exclusively on config('Queue'). If any changes are needed after publishing the config, they can be made manually or through a Registrar.

The queue worker didn’t work with custom config files, and supporting them introduced unnecessary complexity. Sticking to a single config file (similar to how Tasks are handled) offers a cleaner and more predictable approach.

Fixes #57

An alternative PR, which implements custom config file support: #58

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

michalsn avatar Apr 17 '25 13:04 michalsn

Pull Request Test Coverage Report for Build 14516422233

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.011%

Totals Coverage Status
Change from base Build 14492436654: 0.0%
Covered Lines: 668
Relevant Lines: 726

💛 - Coveralls

coveralls avatar Apr 17 '25 13:04 coveralls

Thank you @samsonasik ans @paulbalandan

michalsn avatar May 05 '25 06:05 michalsn