CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

fix(core): resolve PHPStan iterable type errors (#8732)

Open Chucho-Kun opened this issue 1 month ago • 3 comments

Description PHPStan errors were eliminated by reducing the baseline to 1200 errors as part of my contribution to the good first issue label The modifications is in the branch fix/issue-8732-basemodel-types and were validated with the following command

composer phpstan:check -- --memory-limit=512M

Chucho-Kun avatar Nov 19 '25 18:11 Chucho-Kun

Hi there, Chucho-Kun! :wave:

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

[!IMPORTANT] We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

mergeable[bot] avatar Nov 19 '25 18:11 mergeable[bot]

Thank you. Please omit any modifications related to Kint, since it was already updated in #9802.

michalsn avatar Nov 19 '25 19:11 michalsn

For the BasicModel, I recently closed PR. We could not agree on the rules of phpDoc - phpstan or simple types.

I stopped correcting the typing.

neznaika0 avatar Nov 20 '25 03:11 neznaika0