CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

docs: Some typos in cli/cli_library.rst

Open obozdag opened this issue 1 year ago • 2 comments

Description Some typos in cli/cli_library.rst

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [x] User guide updated
  • [ ] Conforms to style guide

obozdag avatar Jun 09 '24 09:06 obozdag

@kenjis, @paulbalandan I didn't say "the industry's standard" is incorrect. In this code example for wrap() method:

$descriptions = [
    'Lorem Ipsum is simply dummy text of the printing and typesetting industry.',
    "Lorem Ipsum has been the industry's standard dummy text ever since the",
];

$descriptions array has two elements. One string element is single quoted, second is double quoted. Why? Only because the second has a single quotation mark in it. I tried to make the quotation marks the same in two elements to keep the readers attention on what wrap() method does. I have changed the quotation marks to single in the second element and as a natural result of this change I have changed the output on line 206. Whatever the text In this example is not important. But if you say that we should keep the example as is, I can roll back the changes. Or you can offer another sentence which doesn't distract user's attention.

obozdag avatar Jun 13 '24 07:06 obozdag

@obozdag thanks for clarifying your intent. in this case let's just use single quotes also and just escape the apostrophe inside: industry\'s

paulbalandan avatar Jun 13 '24 07:06 paulbalandan

This seems abandoned for a long time. Please open a new PR with fresh changes. Thanks!

paulbalandan avatar Jan 19 '25 17:01 paulbalandan