CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

fix: Redis cache handler deleteMatching() not working when a prefix is being used

Open TeamTizo opened this issue 1 year ago • 1 comments

deleteMatching wasn't working for Redis cache when a prefix was being used. adding prefix here fixed the issue.

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

TeamTizo avatar May 09 '24 11:05 TeamTizo

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

[!IMPORTANT] We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

kenjis avatar May 09 '24 11:05 kenjis

If you send a PR, you must add test code for it. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

This PR will not be merged because there is no test code. Next time you submit a PR, be sure to include the test code. Thank you.

kenjis avatar Jun 12 '24 03:06 kenjis

Closed by #8952

kenjis avatar Jun 12 '24 03:06 kenjis