CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

feat: add support for PostgreSQL application_name in DSN

Open myalcin81 opened this issue 1 year ago • 2 comments

Description PostgreSQL has application_name support and its implemented.

Checklist:

  • [ ] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

myalcin81 avatar May 04 '24 19:05 myalcin81

You can configure it as:

    public array $default = [
        'DSN'=> "host=localhost port=5432 user=postgres password='postgres' dbname=test options='--application_name=CI4'",
        // ...
    ]; 

So this is an enhancement. So you should send this PR to 4.6 branch. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#if-you-sent-to-the-wrong-branch

kenjis avatar May 05 '24 01:05 kenjis

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

[!IMPORTANT] We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

kenjis avatar May 05 '24 01:05 kenjis

[!IMPORTANT] We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

This PR does not have the necessary test code. If you want this PR to be reviewed, please add the test code. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

If the test is not added, this PR will be closed.

kenjis avatar Aug 21 '24 09:08 kenjis