CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

fix: [OCI8] Bug: Argument #1 ($value) must be of type ?int, string given

Open allyblaise opened this issue 10 months ago • 2 comments

Fixes #8809

cast $this->port to string on ctype_digit of OCI8 Connection

Checklist:

  • [ ] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [ ] Conforms to style guide

allyblaise avatar Apr 19 '24 12:04 allyblaise

Thank you for sending this PR.

First of all, you must sign all your git commits. We never accept PRs without GPG signing. See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/signing.md

Next, please fix failed checks in GitHub Actions.

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#contributions

kenjis avatar Apr 19 '24 21:04 kenjis

I don't think this is the fix for the referenced issue. The issue is on BaseBuilder::limit() called on Model which complains of string value. Then, this fix forces a string port. So I think this is a fix to a different issue.

paulbalandan avatar Apr 22 '24 14:04 paulbalandan

I do not see why this PR should be merged. If you send PRs, please describe why.

kenjis avatar May 25 '24 06:05 kenjis