CodeIgniter4
CodeIgniter4 copied to clipboard
feat: fix spark db:table causes errors with table name including special chars
Description Superesedes #8696 Fixes #6765
- add
TableNameclass - fix
spark db:tablecauses errors with table name including special chars
$ ./spark db:table
CodeIgniter v4.5.1 Command Line Tool - Server Time: 2024-05-02 02:19:47 UTC+00:00
+-----------+----------+----------+----------+----------+------+
| hostname | database | username | DBDriver | DBPrefix | port |
+-----------+----------+----------+----------+----------+------+
| localhost | ci4 | root | MySQLi | | 3306 |
+-----------+----------+----------+----------+----------+------+
Here is the list of your database tables:
[0] , CONCAT('',`password`) AS `email`
[1] migrations
Which table do you want to see? [0, 1]: 0
Data of Table ", CONCAT('',`password`) AS `email`":
+----+------+
| id | name |
+----+------+
Checklist:
- [x] Securely signed commits
- [x] Component(s) with PHPDoc blocks, only if necessary or adds value
- [x] Unit testing, with >80% coverage
- [x] User guide updated
- [x] Conforms to style guide
:wave: Hi, @kenjis!
We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!
Ref: Syncing Your Branch
:wave: Hi, @kenjis!
We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!
Ref: Syncing Your Branch
:wave: Hi, @kenjis!
We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!
Ref: Syncing Your Branch
:wave: Hi, @kenjis!
We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!
Ref: Syncing Your Branch
:wave: Hi, @kenjis!
We detected conflicts in your PR against the base branch :speak_no_evil:
You may want to sync :arrows_counterclockwise: your branch with upstream!
Ref: Syncing Your Branch
@datamweb Thank you!
@codeigniter4/core-team @codeigniter4/database-team Can you review?
Is there a scenario, when the developer will want to use this new class directly?
I don't know there is the need. At least, there seems to be no request.
So I added @internal to the new class for now.
If there is really demand, let's remove @internal and add the docs.
Sounds fair to me. Thank you!