CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

chore: commenting unverified PR

Open ddevsr opened this issue 1 year ago • 2 comments

Description See PHPDevsr/playground#5.

Checklist:

  • [x] Securely signed commits
  • [ ] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [ ] Unit testing, with >80% coverage
  • [ ] User guide updated
  • [x] Conforms to style guide

ddevsr avatar Mar 19 '24 09:03 ddevsr

Warning: For workflows that are triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission unless the permissions key is specified and the workflow can access secrets, even when it is triggered from a fork. Although the workflow runs in the context of the base of the pull request, you should make sure that you do not check out, build, or run untrusted code from the pull request with this event. Additionally, any caches share the same scope as the base branch. To help prevent cache poisoning, you should not save the cache if there is a possibility that the cache contents were altered. For more information, see "Keeping your GitHub Actions and workflows secure: Preventing pwn requests" on the GitHub Security Lab website. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

kenjis avatar Mar 19 '24 11:03 kenjis

@ddevsr Are you confident that this workflow is 100% secure? If the secret is stolen, it would be a major security incident.

kenjis avatar Mar 19 '24 11:03 kenjis