CodeIgniter4
CodeIgniter4 copied to clipboard
refactor: small improvement in `loadInNamespace` Autoloader
Description Move function call in nested loop to outside.
Checklist:
- [x] Securely signed commits
- [x] Component(s) with PHPDoc blocks, only if necessary or adds value
- [ ] Unit testing, with >80% coverage
- [ ] User guide updated
- [x] Conforms to style guide
I'm not sure, but the code should be like this?
foreach ($this->prefixes as $namespace => $directories) {
if (strpos($class, $namespace) === 0) {
$relativeClassPath = str_replace('\\', DIRECTORY_SEPARATOR, substr($class, strlen($namespace)));
foreach ($directories as $directory) {
$directory = rtrim($directory, '\\/');
$filePath = $directory . $relativeClassPath . '.php';
$filename = $this->includeFile($filePath);
if ($filename) {
return $filename;
}
}
}
}
I'm not sure, but the code should be like this?
foreach ($this->prefixes as $namespace => $directories) { if (strpos($class, $namespace) === 0) { $relativeClassPath = str_replace('\\', DIRECTORY_SEPARATOR, substr($class, strlen($namespace))); foreach ($directories as $directory) { $directory = rtrim($directory, '\\/'); $filePath = $directory . $relativeClassPath . '.php'; $filename = $this->includeFile($filePath); if ($filename) { return $filename; } } } }
@kenjis Thankyou suggest, l like that cut unused loop directory if not exists class namespace
@ddevsr Thank you!