CodeIgniter4 icon indicating copy to clipboard operation
CodeIgniter4 copied to clipboard

[QueryBuilder] `*Batch()` methods are inconsistant

Open kenjis opened this issue 3 years ago • 1 comments

set*Batch()

public function setInsertBatch($key, string $value = '', ?bool $escape = null);
public function setUpdateBatch($key, string $index = '', ?bool $escape = null);

setUpdateBatch() does not have $value.

*Batch()

public function insertBatch(?array $set = null, ?bool $escape = null, int $batchSize = 100);
public function updateBatch(?array $set = null, ?string $index = null, int $batchSize = 100);

updateBatch() does not have $escape.

References

  • #5134
  • #5148
  • #5674
  • #6153
  • #6294

kenjis avatar Jul 29 '22 23:07 kenjis

Related: https://github.com/codeigniter4/CodeIgniter4/pull/6407/ https://github.com/codeigniter4/CodeIgniter4/issues/5149

sclubricants avatar Sep 07 '22 19:09 sclubricants

Closed by #6536

kenjis avatar Sep 27 '22 06:09 kenjis